Closed
Bug 1016399
Opened 11 years ago
Closed 11 years ago
Clang Static Analysis: Remove never used value to fix a minor warning found by scan-build.
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla32
People
(Reporter: axel.viala, Assigned: axel.viala)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
1.42 KB,
patch
|
ehsan.akhgari
:
review+
|
Details | Diff | Splinter Review |
The attached patch fixes a warning detected by scan-build, the clang static analyser.
Attachment #8429316 -
Flags: review?(ehsan)
|
Assignee | |
Updated•11 years ago
|
Blocks: clang-based-analysis
|
|
Assignee | |
Updated•11 years ago
|
Component: Build Config → Networking
|
||
Updated•11 years ago
|
Component: Networking → DOM: Core & HTML
|
||
Comment 1•11 years ago
|
||
Similar to bug 1016422, can you please let us know which warning this is trying to fix? Thanks!
Flags: needinfo?(axel.viala)
|
|
Assignee | |
Updated•11 years ago
|
Flags: needinfo?(axel.viala)
|
|
||
Comment 3•11 years ago
|
||
Comment on attachment 8429316 [details] [diff] [review]
fix-unused-variables.diff
Review of attachment 8429316 [details] [diff] [review]:
-----------------------------------------------------------------
OK yeah this makes sense! Congrats on getting your first patch into our tree! :-)
Attachment #8429316 -
Flags: review?(ehsan) → review+
|
|
||
Comment 4•11 years ago
|
||
Note to sheriffs: this patch is trivial and doesn't require a try server run. I promise!
Keywords: checkin-needed
|
||
Comment 6•11 years ago
|
||
Assignee: nobody → axel.viala
Keywords: checkin-needed
|
|
||
Comment 7•11 years ago
|
||
Status: UNCONFIRMED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
|
|
Assignee | |
Comment 8•11 years ago
|
||
Thanks! ;)
You need to log in
before you can comment on or make changes to this bug.
Description
•